Skip to content

Conversation

@Mingun
Copy link
Collaborator

@Mingun Mingun commented Nov 14, 2025

No description provided.

@Mingun Mingun added the namespaces Issues related to namespaces support label Nov 14, 2025
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 58.21%. Comparing base (d1acdb5) to head (d988704).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/de/mod.rs 50.00% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #913      +/-   ##
==========================================
+ Coverage   58.08%   58.21%   +0.12%     
==========================================
  Files          42       42              
  Lines       15513    15479      -34     
==========================================
  Hits         9011     9011              
+ Misses       6502     6468      -34     
Flag Coverage Δ
unittests 58.21% <75.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

/// # quick_xml::Result::Ok(())
/// ```
#[inline]
#[deprecated = "Use `.resolver().bindings()` instead"]
Copy link
Collaborator

@dralley dralley Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have a concrete idea of which release it will be removed in completely, it might be good to list that. Up to you.

However either there should be an issue filed to remove the deprecated bits.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have a concrete idea of which release it will be removed in completely, it might be good to list that.

Yes, it will be good addition. It will be next minor. I already have a commit that actually removes them. I could open such PR immediately.

…resolve_element()` of `NsReader`

Use `NamespaceResolver` methods instead of `NsReader` methods
@Mingun Mingun merged commit 439047e into tafia:master Nov 14, 2025
7 checks passed
@Mingun Mingun deleted the deprecation branch November 14, 2025 17:30
@Mingun Mingun mentioned this pull request Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

namespaces Issues related to namespaces support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants