-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily remove Gaggle support, upgrade all dependencies #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jeremyandrews
commented
Dec 3, 2022
•
edited
Loading
edited
- Remove all Gaggle functionality (to be restored in a future release with asynchronous logic; use Goose 0.16.4 with Tokio 1.15 if you require Gaggle support)
- update tokio to 1.21; closes update to tokio 1.16 #419; closes Cargo.toml: upgrade dependencies #510;
- update tungestenite to 0.18; rework controller tests to be asynchronous; closes [WIP] Update to tokio 1.16 #420
jeremyandrews
force-pushed
the
degaggle
branch
2 times, most recently
from
December 3, 2022 14:35
bfb3a60
to
701fb9d
Compare
jeremyandrews
force-pushed
the
degaggle
branch
from
December 3, 2022 14:41
701fb9d
to
1647bc9
Compare
jeremyandrews
force-pushed
the
degaggle
branch
from
December 6, 2022 11:08
886fda7
to
8b514c3
Compare
jeremyandrews
changed the title
[WIP] Temporarily remove Gaggle support, upgrade all dependencies
Temporarily remove Gaggle support, upgrade all dependencies
Dec 8, 2022
LionsAd
approved these changes
Dec 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not check every line, but overall looks great!
jeremyandrews
force-pushed
the
degaggle
branch
from
December 8, 2022 15:29
b45cf30
to
16ffcac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.