[lang] Free ndarray memory on the base class #8764
Open
+8
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
classes inheriting from Ndarray should have their memory released
Issue: #8763
Brief Summary
ScalarNdarray implements del() to allow python to get rid of the allocated memory,
but other subclasses of Ndarray (like VectorNdarray() or MatrixNdarray()) don't implement the same behaviour.
Seems to me the del() method should be moved to the Ndarray class.
I tested this simple change and indeed it fixes the memory leak.
Walkthrough
If, instead:
Note
Move deletion logic to
Ndarray.__del__
so all ndarray variants free device memory; remove subclass-specific__del__
fromScalarNdarray
.Ndarray.__del__
to delete underlyingarr
viart.prog.delete_ndarray(...)
when runtime/program exist.ScalarNdarray.__del__
; destruction is now handled centrally by base class for all ndarray subclasses.python/taichi/lang/_ndarray.py
to centralize deletion logic and add safety checks (impl/arr/runtime/prog
presence).Written by Cursor Bugbot for commit 4e58132. This will update automatically on new commits. Configure here.