Skip to content

Conversation

@taiko-kitty
Copy link
Contributor

@taiko-kitty taiko-kitty commented Nov 24, 2025

🤖 I have created a release beep boop

0.6.1 (2025-11-26)

Chores

  • block: remove an unnecessary method override for ConfigureEvm (#69) (588e077)
  • consensus: rename ANCHOR_V3_GAS_LIMIT to ANCHOR_V3_V4_GAS_LIMIT (#65) (9d9899d)

This PR was generated with Release Please. See documentation.

@claude
Copy link

claude bot commented Nov 24, 2025

Claude finished @taiko-kitty's task —— View job


Review Complete


Code Review

This is a standard release-please PR for v0.6.1 containing a single chore commit. The release looks clean with proper version bumps across all required files.

The Core Change (PR #65)

Issue Found - Documentation/Implementation Mismatch:

The constant rename from ANCHOR_V3_GAS_LIMIT to ANCHOR_V3_V4_GAS_LIMIT updates the documentation to say it applies to "Pacaya and Shasta hardfork blocks", but the implementation doesn't match this claim:

crates/consensus/src/validation.rs:285-289:

let gas_limit = if chain_spec.is_pacaya_active_at_block(block.number()) {
    ANCHOR_V3_V4_GAS_LIMIT  // Only checks Pacaya, not Shasta
} else {
    ANCHOR_V1_V2_GAS_LIMIT
};

The code only checks is_pacaya_active_at_block(), not is_shasta_active(). Since Shasta comes after Pacaya chronologically, this works in practice (Pacaya activation implies the gas limit applies to all subsequent hardforks including Shasta), but the comment is misleading.

Recommendation: Either:

  1. Update the comment to accurately reflect the implementation: "The gas limit for anchor transactions from Pacaya hardfork onwards (including Shasta)"
  2. Or update the code to explicitly check both hardforks if that's the intended semantics

Minor Observations:

  • Version bump from 0.6.0 → 0.6.1 is appropriate for a chore commit
  • CHANGELOG entry follows conventional commit format correctly
  • The constant rename itself is properly applied in all usage locations (crates/consensus/src/validation.rs:46 and :286)

Release Files

  • .release-please-manifest.json: ✓ Version updated correctly
  • Cargo.toml: ✓ Workspace version updated correctly
  • CHANGELOG.md: ✓ Entry properly formatted

Overall Assessment

Approve with minor documentation clarification recommended. The release is safe to merge as-is, but consider addressing the documentation/implementation mismatch in a follow-up.


@taiko-kitty taiko-kitty force-pushed the release-please--branches--main branch from d00ca32 to 45f3c15 Compare November 26, 2025 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants