feat(evm): implement jumpdest limiter #68
Draft
+463
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidtaikocha
changed the title
johntaiko
reviewed
Nov 25, 2025
crates/evm/src/jumpdest_limiter.rs
Outdated
| impl<CTX> Inspector<CTX, EthInterpreter> for JumpdestLimiter { | ||
| fn initialize_interp(&mut self, _interp: &mut Interpreter<EthInterpreter>, _ctx: &mut CTX) { | ||
| // Reset per top-level transaction. | ||
| self.count = 0; |
Member
There was a problem hiding this comment.
resets count in initialize_interp, which revm calls for every frame (each CALL/CREATE). After the first call, the earlier JUMPDEST executions are forgotten, so the limiter effectively applies per frame, not per top-level transaction as the comment suggests; a contract can bypass the limit by recursing. Reset only when depth is 0 (e.g., via ctx.journaled_state.depth()) or reset once per tx outside the frame init path.
Author
There was a problem hiding this comment.
thanks, I found out when I was writing tests, next commit is fixing it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.