Skip to content

fix(3384): improve Windows installation with MSVC detection and better errors #3386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

luffy-orf
Copy link

@luffy-orf luffy-orf commented May 6, 2025

Fixes issue #3384 where Tailcall CLI isn't recognized on Windows after installation.

  • Adds MSVC detection for Windows installations
  • Improves error handling with descriptive messages
  • Adds process.exit(1) on installation failure
  • Updates README with Windows requirements

/claim #3384


Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions bot added the type: fix Iterations on existing features or infrastructure. label May 6, 2025
@luffy-orf luffy-orf changed the title fix: improve Windows installation with MSVC detection and better errors fix(3384): improve Windows installation with MSVC detection and better errors May 6, 2025
@tusharmath
Copy link
Contributor

I am not sure if this will solve the issue. The problem is that the correct binary is not being installed. If msvc was a problem, it would have installed but not executed.

@luffy-orf
Copy link
Author

I am not sure if this will solve the issue. The problem is that the correct binary is not being installed. If msvc was a problem, it would have installed but not executed.

I can see the Windows binaries need the .exe extension and there's special handling for this in the build process. Then i will add checks to verify the actual binary exists after installation

@luffy-orf
Copy link
Author

@tusharmath I have added binary verification for windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙋 Bounty claim type: fix Iterations on existing features or infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants