Skip to content

Commit e3d4a3d

Browse files
gitttt-1234claude
andcommitted
Update test assertions to match new default values
Updated test_dataloader_config and test_trainer_config to expect: - batch_size: 4 (instead of 1) - max_epochs: 100 (instead of 10) - seed: None (instead of 0) All tests now pass with the updated configuration defaults. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent e09b987 commit e3d4a3d

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

tests/config/test_trainer_config.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,15 +67,15 @@ def test_dataloader_config():
6767
conf = OmegaConf.structured(TrainDataLoaderConfig)
6868
conf_instance = OmegaConf.structured(TrainDataLoaderConfig())
6969
assert conf == conf_instance
70-
assert conf.batch_size == 1
70+
assert conf.batch_size == 4
7171
assert conf.shuffle is True
7272
assert conf.num_workers == 0
7373

7474
# Check default values
7575
conf = OmegaConf.structured(ValDataLoaderConfig)
7676
conf_instance = OmegaConf.structured(ValDataLoaderConfig())
7777
assert conf == conf_instance
78-
assert conf.batch_size == 1
78+
assert conf.batch_size == 4
7979
assert conf.shuffle is False
8080
assert conf.num_workers == 0
8181

@@ -211,9 +211,12 @@ def test_trainer_config(caplog):
211211
conf_dict = asdict(conf) # Convert to dict for OmegaConf
212212
conf_structured = OmegaConf.create(conf_dict)
213213

214-
assert conf_structured.train_data_loader.batch_size == 1
214+
assert conf_structured.train_data_loader.batch_size == 4
215+
assert conf_structured.val_data_loader.batch_size == 4
215216
assert conf_structured.val_data_loader.shuffle is False
216217
assert conf_structured.model_ckpt.save_top_k == 1
218+
assert conf_structured.max_epochs == 100
219+
assert conf_structured.seed is None
217220
assert conf_structured.optimizer.lr == 1e-4
218221
assert conf_structured.lr_scheduler is not None
219222
assert conf_structured.lr_scheduler.reduce_lr_on_plateau is not None

0 commit comments

Comments
 (0)