fix: windows separators #548
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunnerh
reviewed
Jun 12, 2024
| // glob has issues with windows separators, so we need to replace them | ||
| const globPath = join(dir, `**/*.${ASSETS_EXTENSION}`).replace(/\\/g,'/'); | ||
|
|
||
| const files = await glob(globPath, {}); |
There was a problem hiding this comment.
This should be an alternative to the replacement:
Suggested change
| const files = await glob(globPath, {}); | |
| const files = await glob(globPath, { windowsPathsNoEscape: true }); |
Not sure which is better, though.
If doing it that way, the join should probably not use a specific separator for consistency:
join(dir, '**', `*.${ASSETS_EXTENSION}`)
|
This closes/fixes: Edit: Also a duplicate of: (Though this PR is more up to date.) |
|
up |
|
@tancredi please review, and merge it, we need those feature, coz we used bun for install, and any solution with overrride glob will not work in bun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.