feat(tangle-cloud): Implement blueprint instance deployment page #2918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tangle-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for tangle-cloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for tangle-leaderboard canceled.
|
yuri-xyz
changed the title
Contributor
Author
|
@danielbui12 I just wrote the |
yuri-xyz
changed the title
yuri-xyz
changed the title
yuri-xyz
changed the title
5 tasks
Contributor
|
@yurixander do you plan to finish this soon or should we hand it to @danielbui12 ? |
danielbui12
force-pushed
the
yuri/create-services-txs
branch
from
e709311 to
c01c40c
Compare
✅ Deploy Preview for tangle-leaderboard ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
danielbui12
requested review from
AtelyPham,
danielbui12,
devpavan04 and
monaiuu
as code owners
danielbui12
added
needs review 👓
app: tangle-cloud ☁️
on hold ⛔️
Contributor
|
need to merge #2937 first |
5 tasks
yuri-xyz
commented
Apr 1, 2025
apps/tangle-cloud/src/pages/registrationReview/RegistrationForm/FieldTypeInput.tsx
Show resolved
Hide resolved
| onSave={(params) => { | ||
| tokenSymbol={network.tokenSymbol} | ||
| amountValue={amount[blueprint.id] ?? ''} | ||
| paramsValue={registrationParams[blueprint.id] ?? {}} |
Contributor
Author
There was a problem hiding this comment.
Might be good to put this on a useMemo
Contributor
There was a problem hiding this comment.
This is in map to render component, not a specific value. I tried useMemo got a bug, then I have to unwrap the useMemo
apps/tangle-cloud/src/pages/blueprints/[id]/deploy/DeploySteps/DeployStep1.tsx
Outdated
Show resolved
Hide resolved
apps/tangle-cloud/src/pages/blueprints/[id]/deploy/DeploySteps/DeployStep1.tsx
Show resolved
Hide resolved
apps/tangle-cloud/src/pages/blueprints/[id]/deploy/DeploySteps/DeployStep1.tsx
Outdated
Show resolved
Hide resolved
apps/tangle-cloud/src/pages/blueprints/[id]/deploy/DeploySteps/DeployStep1.tsx
Outdated
Show resolved
Hide resolved
apps/tangle-cloud/src/pages/blueprints/[id]/deploy/DeploySteps/DeployStep1.tsx
Outdated
Show resolved
Hide resolved
Contributor
|
Why is the diff so large? Package lock? |
danielbui12
force-pushed
the
yuri/create-services-txs
branch
from
6451293 to
3eacf86
Compare
danielbui12
added
needs review 👓
and removed
on hold ⛔️
danielbui12
reviewed
Apr 2, 2025
| }; | ||
| }); | ||
|
|
||
| return data as PrimitiveField[]; |
Contributor
There was a problem hiding this comment.
@yuri-xyz The type is too malicious to be covered so it's better to cast here
github-project-automation
bot
moved this from Building 🏗️
to Completed ✅
in Tangle Universe
danielbui12
added a commit
that referenced
this pull request
Apr 3, 2025
Co-authored-by: danielbui12 <[email protected]> Co-authored-by: yurixander <[email protected]> Co-authored-by: Trung-Tin Pham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Provide a detailed description of proposed changes.
/deploypage that allows setting up a blueprint instance's settings for deployment.Proposed area of change
Put an
xin the boxes that apply.apps/tangle-dappapps/tangle-cloudapps/leaderboardlibs/tangle-shared-uilibs/ui-componentsAssociated issue(s)
Specify any issues that can be closed from these changes (e.g.
Closes #233).Screen Recording
If possible provide screenshots and/or a screen recording of proposed change.
deploy_blueprint_step_1.mov