Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tile fallback #2119

Closed
wants to merge 4 commits into from
Closed

Tile fallback #2119

wants to merge 4 commits into from

Conversation

rwrx
Copy link
Contributor

@rwrx rwrx commented Dec 17, 2019

I have checked this in my app using mbtiles and it seems to be working properly despite proxy tiles are used. Could I ask you to check it too when you will have some time if it is working properly with mbtiles? From my testing everything worked, but maybe there is something that I am not aware of.

@matteblair
Copy link
Member

This seems to be two separate changes: 1) "Add support for multiple mbtiles files through urls_mbtiles" and 2) "Add tile fallback". If these changes are unrelated, it would be best to submit them as two separate PRs, so that we can test and discuss them independently.

For the "multiple mbtiles" change, can you give an example use case and show how the new parameter would be used in YAML?

For the "tile fallback" change, can you describe:
- The use case you are aiming to support
- The current behavior in this use case, and how it doesn't meet your needs
- The new behavior you've implemented

Thanks!

@rwrx
Copy link
Contributor Author

rwrx commented Dec 18, 2019

@matteblair thank you a lot for the answer. I am sorry but I have must created rather a new pull request #2120 and I added comments as you requested.

@rwrx rwrx closed this Dec 18, 2019
@rwrx rwrx deleted the tile-fallback2 branch December 18, 2019 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants