[nop] [#176] make deps on compression libs optional #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use reflective calls to interact with org.tukaani/xz and io.airlift/aircompressor so that users of nippy can choose to exclude those dependencies if they aren't using compression. Reflective calls are much slower, and some type-hints were also removed, so these changes might affect performance.
Member
|
@scarytom Hi Tom, thanks for looking into this 🙏 Unfortunately I'm definitely not keen on anything that'd impact performance for typical users. Haven't given this detailed thought since I'm currently focused on other priorities, but in case it's helpful - some other ideas to consider would be: |
ptaoussanis
force-pushed
the
master
branch
6 times, most recently
from
c4537e6 to
2a4347c
Compare
ptaoussanis
force-pushed
the
master
branch
4 times, most recently
from
e848af6 to
b02b375
Compare
ptaoussanis
force-pushed
the
master
branch
7 times, most recently
from
931c416 to
1b99516
Compare
ptaoussanis
force-pushed
the
master
branch
4 times, most recently
from
f7594d5 to
40b3dcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use reflective calls to interact with org.tukaani/xz and io.airlift/aircompressor so that users of nippy can choose to exclude those dependencies if they aren't using compression.
Reflective calls are much slower, and some type-hints were also removed, so these changes might affect performance.