Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cd: publish to RWS #680

Merged
merged 4 commits into from
Jan 26, 2022

Conversation

DifferentialOrange
Copy link
Member

@DifferentialOrange DifferentialOrange commented Jan 24, 2022

Before merge, someone should set RWS_AUTH secret for GitHub Actions.

Change package release policy:

  • drop EL6 (CentOS 6.x, RHEL 6.x, CloudLinux 6.x);
  • drop Fedora 29;
  • drop Ubuntu 14.04 (Trusty);
  • drop Debian 8 (Jessie);
  • add Fedora 31, 32, 33, 34, 35;
  • add Ubuntu 21.04 (Hirsute).

Deprecate workflow_dispatch release flow.

After this patch, package will be published to RWS with curl instead of outdated update-repo.sh script. You can use RWS_URL_PART=URL RWS_AUTH=USER:PWD mage PublishRWS to publish packages built with goreleaser.

I manually tested it with https://test-tarantool-rws.herokuapp.com/release/modules

Closes #679

@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/migrate-release-to-rws branch 2 times, most recently from 2ccebba to c093bfc Compare January 24, 2022 12:55
@Totktonada
Copy link
Member

Added RWS_AUTH secret to the repository.

@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/migrate-release-to-rws branch from c093bfc to 4ae5de7 Compare January 25, 2022 14:45
* Drop EL6 (CentOS 6.x, RHEL 6.x, CloudLinux 6.x).
* Drop Fedora 29.
* Drop Ubuntu 14.04 (Trusty).
* Drop Debian 8 (Jessie).
* Add Fedora 31, 32, 33, 34, 35.
* Add Ubuntu 21.04 (Hirsute).

Part of #679
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/migrate-release-to-rws branch from 4ae5de7 to 798193e Compare January 25, 2022 14:51
Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several comments regarding build/push workflow file.

.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/migrate-release-to-rws branch from 798193e to ea0efc3 Compare January 25, 2022 14:55
magefile.publish.go Outdated Show resolved Hide resolved
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/migrate-release-to-rws branch from 84a3abd to 134fc3c Compare January 25, 2022 15:25
Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections from me.

Please, solve the Fedora 35 problem with @LeonidVas and proceed.

@DifferentialOrange
Copy link
Member Author

No objections from me.

Please, solve the Fedora 35 problem with @LeonidVas and proceed.

@LeonidVas said he'll add it after review

Copy link
Collaborator

@LeonidVas LeonidVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thank you for the patch.
If the patchset is working, then I like it.
See several nits bellow.

magefile.publish.go Show resolved Hide resolved
magefile.publish.go Show resolved Hide resolved
magefile.publish.go Show resolved Hide resolved
magefile.publish.go Show resolved Hide resolved
magefile.publish.go Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/migrate-release-to-rws branch 2 times, most recently from 866d5cd to 484ece4 Compare January 25, 2022 16:49
@DifferentialOrange
Copy link
Member Author

Hi! Thank you for the patch. If the patchset is working, then I like it. See several nits bellow.

I used RWS_URL_PART=https://test-tarantool-rws.herokuapp.com/release/modules RWS_AUTH=USER:PWD mage PublishRWS and artifacts are there.

image

image

magefile.publish.go Outdated Show resolved Hide resolved
After this patch, package will be published to RWS with curl instead of
outdated update-repo.sh script [1]. You can use
``RWS_URL_PART=URL RWS_AUTH=USER:PWD mage PublishRWS`` to publish
packages built with goreleaser.

1. https://github.com/tarantool/tarantool/blob/c9e3926e5ae82785c5eb494521c44ba522109e95/tools/update_repo.sh

Closes #679
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/migrate-release-to-rws branch from 484ece4 to 9b4691e Compare January 26, 2022 07:18
Mono server starts unexpectedly on GitHub Actions. It uses 8084 port
that is used for tests, so we kill it before running tests.
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/migrate-release-to-rws branch from 97800a5 to e9387f7 Compare January 26, 2022 09:12
@DifferentialOrange DifferentialOrange merged commit 6242ccd into master Jan 26, 2022
@DifferentialOrange DifferentialOrange deleted the DifferentialOrange/migrate-release-to-rws branch January 26, 2022 10:22
DifferentialOrange added a commit that referenced this pull request Jan 26, 2022
This patch cleans up commands used to debug CI/CD in PR #680
DifferentialOrange added a commit that referenced this pull request Jan 26, 2022
This patch cleans up commands used to debug CI/CD in PR #680
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move CD to RWS
3 participants