drop migration path for the config file #497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, it systematically fails: ```shell $ dune-release [-] Upgrading configuration files: /home/foo/.dune => /home/foo/.config/dune dune-release: [ERROR] move /home/foo/.dune to /home/foo/.config/dune/release.yml: Destination exists ``` when using dune package management, due to dune getting installed to ~/.dune/bin/dune. Considering that: - the migration code from 2018 - it doesn't work at all, since aside from failing unnecessarily, it would also mess things up by renaming the directory ~/.dune to ~/.config/dune/dune/release.yml I see no reason to salvage this code.
|
FYI: Dune package management is installing to |
|
Right, but it doesn't remove any previous installed dune, and no reason to keep nonfunctional code. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it systematically fails:
$ dune-release [-] Upgrading configuration files: /home/foo/.dune => /home/foo/.config/dune dune-release: [ERROR] move /home/foo/.dune to /home/foo/.config/dune/release.yml: Destination existswhen using dune package management, due to dune getting installed to
~/.dune/bin/dune.
Considering that:
also mess things up by renaming the directory ~/.dune to
~/.config/dune/dune/release.yml
I see no reason to salvage this code.
The second commit cleans up some Result.t that have become infallible.