-
Notifications
You must be signed in to change notification settings - Fork 37
dev meeting 20210120
Present at the meeting:
- Guillaune Petiot (@gpetiot)
- Sonja Heinze (@pitag-ha)
- Nathan Rebours (@NathanReb)
- Sonja polishes the
check
command PR so it can be reviewed - Sonja looks into @kit-ty-kate's PR, allowing dune-release to skip release creation if the right release already exists
- Guillaume brings the "Sanitize versions before creating tags" PR back to life
- Once the above is done, Guillaume and Nathan look into the draft mode to fix the remaining issues
- Nathan reviews and merge the last features/bug fixes and cuts the 1.5.0 release
- Nathan announces the 1.5.0 release and the plans for 2.0.0 on discuss
Nathan reviewed most of Guillaume's recent bug fixes and they have since been merged. He also went through the remaining existing PRs and created a 1.5.0 milestone with the ones that we want to merge before the release.
Sonja worked on delegates deprecation (ready) and check command. The check command still needs a bit of polishing but it should be ready for a final review soon.
Guillaume worked on the draft PR. It's virtually ready but two issues remain at the moment:
- We need to figure out why it's not working on Nathan's machine and if it's a bug in the implementation, fix it
- It appears that there's a bug in the github API we use and it doesn't let us actually undraft PRs. We can edit every other aspect of a PR but this one remains unchanged despite our request receiving a success response. The first need to be dealt with but the second isn't so annoying is it only affects the very last step of the undrafting which can then easily be done by hand, simply clicking on a button. We'll look into it to see if github actually plans to fix this part of the API or if the request has to go through a newer version of the API for this to work.
We devised a clear plan from here to the 1.5.0 release. The goal is to release this new version before the next dev meeting two weeks from now, on the 03/02/2021.
We want to include the delegate deprecation but this is already ready to be merged. Remains the check
command and a couple of bug fixes that actually already have opened PRs. We just need to refresh them a bit but there shouldn't be too much work involved.
Given that we're having trouble with the draft mode and that there are plenty of useful feature already we won't make it a blocker for this release. If we manage to get it in a satisfying state before 1.5.0 it's good but otherwise we'll make it part of a 1.6.0 soon after as we'd still like to get some feedback on this feature before releasing 2.0.0.