Replace exceptions by result types for the requests #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
gpetiot
added a commit
to tarides/opam-repository
that referenced
this pull request
Mar 20, 2024
CHANGES: ### Added - Add the `--version` command-line option (tarides/get-activity#13, @gpetiot) - Add a `--user` option to extract the activity of an engineer that is not the current user (tarides/get-activity#14, @gpetiot) - Add the issue comments to the contributions (tarides/get-activity#21, @gpetiot) ### Changed - Replace exceptions by result types for the requests (tarides/get-activity#11, @gpetiot) - Depends on `curly` instead of `cohttp-lwt-unix` (tarides/get-activity#12, @gpetiot) - Redesign the graphql requests (tarides/get-activity#12, @gpetiot) + `Graphql.exec` now takes a `request` + `Contributions.fetch` has been replaced by `Contributions.request` that builds a `request` - Add a `~user:User.t` parameter to `Contributions.request` and `Contributions.of_json` (tarides/get-activity#14, @gpetiot) - `Contributions.of_json` now returns a result type (tarides/get-activity#20, @gpetiot)
samoht
pushed a commit
to samoht/tarides-opam-repository
that referenced
this pull request
Jul 23, 2024
CHANGES: ### Added - Add the `--version` command-line option (tarides/get-activity#13, @gpetiot) - Add a `--user` option to extract the activity of an engineer that is not the current user (tarides/get-activity#14, @gpetiot) - Add the issue comments to the contributions (tarides/get-activity#21, @gpetiot) ### Changed - Replace exceptions by result types for the requests (tarides/get-activity#11, @gpetiot) - Depends on `curly` instead of `cohttp-lwt-unix` (tarides/get-activity#12, @gpetiot) - Redesign the graphql requests (tarides/get-activity#12, @gpetiot) + `Graphql.exec` now takes a `request` + `Contributions.fetch` has been replaced by `Contributions.request` that builds a `request` - Add a `~user:User.t` parameter to `Contributions.request` and `Contributions.of_json` (tarides/get-activity#14, @gpetiot) - `Contributions.of_json` now returns a result type (tarides/get-activity#20, @gpetiot)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the diff of #10