Ci/add OSV scanner v4 #3200
Open
Ci/add OSV scanner v4 #3200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (1)
.github/workflows/osv-scanner.yml:8
- Similar to the pull_request trigger, the merge_group trigger is limited to 'master'. Ensure that the branch specification aligns with the intended legacy branches for vulnerability scanning.
merge_group:
branches: [master]
| schedule: | ||
| - cron: '30 12 * * 1' | ||
| pull_request: | ||
| branches: [master] |
There was a problem hiding this comment.
The PR description indicates that the OSV scanner should also run on legacy branches, but the pull_request trigger is set to 'master' only. Please update the branch filter to include the targeted legacy branches.
Suggested change
| branches: [master] | |
| branches: [master, legacy-branch-1, legacy-branch-2] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
In order to detect all vulnerabilities we need to also run the osv scanner on legacy branches.
How
Added the osv-scanner and upgraded some dependencies
Additional Notes (Optional)
Any extra info here.