feat(worker): support rate limit #3321
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds rate limiting functionality to the Worker class to prevent excessive job processing when rate limits are enforced. This implementation introduces mechanisms to check, wait for, and respect rate limit timeouts.
- Introduces rate limit checking and waiting mechanisms
- Modifies the main worker loop to respect rate limit conditions
- Adds utility methods for managing rate limit delays and timeouts
| @returns a Job or undefined if no job was available in the queue. | ||
| """ | ||
| if not self.waiting and self.drained: | ||
| if self.drained and not self.limitUntil and not self.waiting: |
There was a problem hiding this comment.
The condition not self.limitUntil will be True when limitUntil is 0, but rate limiting should be based on comparing with current timestamp. This could cause incorrect behavior when limitUntil is 0 but should still allow processing. Consider using not self.isRateLimited() instead.
| if self.drained and not self.limitUntil and not self.waiting: | |
| if self.drained and not self.isRateLimited() and not self.waiting: |
|
|
||
| async def delay(self, milliseconds): | ||
| try: | ||
| await asyncio.sleep(milliseconds/1000 or 0.1) |
There was a problem hiding this comment.
The expression milliseconds/1000 or 0.1 will use 0.1 when milliseconds is 0, but it should sleep for 0 seconds when milliseconds is 0. Use await asyncio.sleep(milliseconds/1000) or handle the zero case explicitly.
| await asyncio.sleep(milliseconds/1000 or 0.1) | |
| await asyncio.sleep(milliseconds/1000) |
| return None | ||
|
|
||
| def isRateLimited(self): | ||
| return self.limitUntil > round(time.time() * 1000) |
There was a problem hiding this comment.
This method will raise an AttributeError if self.limitUntil is not initialized. The code assumes limitUntil exists but it's not clear where this attribute is defined or initialized.
| return self.limitUntil > round(time.time() * 1000) | |
| return getattr(self, "limitUntil", 0) > round(time.time() * 1000) |
Co-authored-by: Copilot <[email protected]>
Why
Enter your explanation here.
How
Enter the implementation details here.
Additional Notes (Optional)
Any extra info here.