fix(worker): fix bzpopmin race condition #3326
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
As explained in #2619, the resolution order of setTimeout and bzpopmin under certain conditions is wrong.
How
To reestablish the correct order, I'm scheduling the disconnection for the next tick to let bzpopmin eventually resolve properly.
Additional Notes (Optional)
I'm honestly not sure how to add non-regression testing on this, I'd like some advice on this if possible.
I also removed the async modifier of the timeout callback, not really sure why it was there.