fix(worker): reject promise if retrieving a Redis client fails #3330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manast
reviewed
Jul 7, 2025
Contributor
manast
left a comment
manast
left a comment
There was a problem hiding this comment.
It would be useful to have a test that confirms the error you are resolving. Also, I noticed the code is duplicated, maybe it could be moved to QueueBase instead to avoid the duplication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I noticed that if
await this._clientthrows, the outerPromisedoesn't get rejected, nor resolved.How
As it isn't possible to make a
getasync, the change creates an async anonymous function and immediately executes it.Additional Notes (Optional)
In the future, we could consider not using a
getterbut a regular function. Additionally, the logic is duplicated in bothQueueandWorker.