chore: refactor lock management into separate class #3398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eat/dedicated-thread-lock-extension
…eat/dedicated-thread-lock-extension
roggervalf
reviewed
Oct 2, 2025
| ### Bug Fixes | ||
|
|
||
| * **deps:** upgrade bullmq to 1.80.4 ([#46](https://github.com/taskforcesh/bullmq-pro/issues/46)) ([fc2818f](https://github.com/taskforcesh/bullmq-pro/commit/fc2818f09ddd273b7cc16c54fcd9650e1d456d04)) | ||
| - **deps:** upgrade bullmq to 1.80.4 ([#46](https://github.com/taskforcesh/bullmq-pro/issues/46)) ([fc2818f](https://github.com/taskforcesh/bullmq-pro/commit/fc2818f09ddd273b7cc16c54fcd9650e1d456d04)) |
Collaborator
There was a problem hiding this comment.
no need to apply lint in changelog files, need to restore format
| try { | ||
| await this.checkConnectionError(() => this.moveStalledJobsToWait()); | ||
| } catch (err) { | ||
| this.emit('error', <Error>err); |
Collaborator
There was a problem hiding this comment.
no need for this extra wrapper of try catch as checkConnectionError handles this same emission
| } | ||
|
|
||
| await this.startStalledCheckTimer(); | ||
| this.initializeLockManager(); |
Collaborator
There was a problem hiding this comment.
I do not see useDedicatedLockThread option being used. It's referenced in docs but I cannot see it in lock-manager class or in worker
…eat/dedicated-thread-lock-extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This PR aims to provide a new option when instantiating Workers, so that it is possible to use a dedicated thread for lock extension and job stalling detection. The reason for allowing this, is so that we can have a safer lock renewal mechanism even in the cases where the jobs are not respecting the best practice of not keeping the event loop busy for long periods of time.
How
We refactor the lock handling in a separate class "LockManager" and then we add support to this class to run in a separate thread that communicates with the main process. Note that this approach is not a fail proof solution to the issue of jobs that keep the event loop busy, as it could also happen that the communication between the main thread and the lock extension thread stalls and issues related to locks may still happen, however it should reduce the number of cases when this happens.
Additional Notes (Optional)
Any extra info here.