Skip to content

fix(barcode-scanner): fix the cameraView is not removed after scanning in iOS #2440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v2
Choose a base branch
from

Conversation

kingsword09
Copy link

@kingsword09 kingsword09 commented Feb 20, 2025

On iOS, when windowed = false, the cameraView is not removed from the superView when the scanning is done, making the interface unclickable.

image

When destroy, only the removePreviewLayer was done, not the removeFromSuperview.
image

@kingsword09 kingsword09 requested a review from a team as a code owner February 20, 2025 01:21
@zepyrshut
Copy link

zepyrshut commented Apr 14, 2025

Thank you so much!!! Fixed my problem!! The barcode scanner fully working with iPhone with windowed: false

I copied the plugin folder (barcode-scanner) and fetched it locally

@kingsword09
Copy link
Author

@lucasfernog Is it possible to review the code and release a version if no problem, otherwise everyone who uses this plugin will have to copy a copy locally.

@kingsword09 kingsword09 force-pushed the v2-barcode-scanner-ios-framework branch from 7880629 to 48b306c Compare April 15, 2025 00:30
Copy link
Contributor

github-actions bot commented Apr 15, 2025

Package Changes Through 1c66cba

There are 4 changes which include log with minor, log-js with minor, barcode-scanner with patch, barcode-scanner-js with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
api-example 2.0.24 2.0.25
api-example-js 2.0.20 2.0.21
barcode-scanner 2.2.0 2.2.1
barcode-scanner-js 2.2.0 2.2.1
log 2.3.1 2.4.0
log-js 2.3.1 2.4.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@kingsword09 kingsword09 force-pushed the v2-barcode-scanner-ios-framework branch from 48b306c to 1c66cba Compare April 15, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants