Skip to content

Conversation

@owtotwo
Copy link

@owtotwo owtotwo commented Mar 5, 2025

Problem

As mentioned here

Detials

set_maximized(false) will fire the SW_RESTORE, and it disturbs the state of the borderless fullscreen.
To be precise, the window size that should have kept the full screen has been changed (to normal window size).

Solution

  1. Use SetWindowLongW(... !WS_MAXIMIZE ...) instead of ShowWindow(..., SW_RESTORE) to set the maximized state off.
  2. Use placement.showCmd to make it correct for set_fullscreen(false) when the window is maximized or not.

@owtotwo owtotwo requested a review from a team as a code owner March 5, 2025 09:50
@lucasfernog lucasfernog requested a review from amrbashir March 7, 2025 10:40
@github-actions
Copy link
Contributor

Package Changes Through 13bccdb

There are 1 changes which include tao with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tao 0.32.8 0.32.9

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant