Skip to content

fix: maximization for non decoration window, closes #464 #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: maximization for non decoration window, closes #464 #469

wants to merge 1 commit into from

Conversation

@keiya01
Copy link
Member

@keiya01 keiya01 commented Jul 10, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@keiya01 keiya01 requested a review from a team as a code owner July 10, 2022 06:03
@keiya01 keiya01 linked an issue Jul 10, 2022 that may be closed by this pull request
set_maximized(true) ignores window maximum size when decorations is set to false #464
Open
@keiya01 keiya01 mentioned this pull request Jul 10, 2022
Open
@keiya01 keiya01 force-pushed the fix/maximizing-window-macos branch from f34e275 to d1b2366 Compare July 10, 2022 06:04
@amrbashir amrbashir mentioned this pull request Jul 25, 2022
Open
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

set_maximized(true) ignores window maximum size when decorations is set to false

2 participants

@keiya01