-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance(core): use sync commands for window and webview getters #12162
base: dev
Are you sure you want to change the base?
enhance(core): use sync commands for window and webview getters #12162
Conversation
Package Changes Through e89f966There are 1 changes which include tauri with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
I believe we used to have them sync but it caused dead locks somewhere, I think @lucasfernog has more info about this |
I'm pretty sure we'll have deadlocks if we do this :/ |
Do you know any particular places where the deadlock will happen? If we can't fix them, maybe it's a good idea to document the problem, I have encountered this before trying to call |
This reverts commit 6a56b26.
Reference: #12032
I don't quite know the reason behined why all window and webview commands are async, seems like for the setters, they would trigger events during the call and causing dead locks, but I can't see any reason for the getters, let me know if this was actually intentional or not