Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow overriding .rpm and .deb package names #12385

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

AlexProgrammerDE
Copy link
Contributor

My app SoulFire gets renamed to the package name soul-fire, which I don't want. I want it to be called soulfire. This is why I need these changes. There was also a discord conversation about this: https://discord.com/channels/616186924390023171/986184094050316358/1328375059919671336

@AlexProgrammerDE AlexProgrammerDE requested a review from a team as a code owner January 13, 2025 15:27
# Conflicts:
#	crates/tauri-bundler/src/bundle/linux/debian.rs
#	crates/tauri-bundler/src/bundle/linux/rpm.rs
@AlexProgrammerDE AlexProgrammerDE force-pushed the dev branch 3 times, most recently from 44ebcbe to 7933fee Compare January 13, 2025 15:34
@AlexProgrammerDE AlexProgrammerDE force-pushed the dev branch 2 times, most recently from d98331c to 5c99b3b Compare January 13, 2025 15:45
Copy link
Contributor

github-actions bot commented Jan 13, 2025

Package Changes Through 2678361

No changes.

Add a change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@FabianLars FabianLars added this to the 2.4 milestone Feb 26, 2025
@lucasfernog
Copy link
Member

what about adding a src-tauri/tauri.linux.conf.json with the following contents instead:

{
  "productName": "soufire"
}

wouldn't that be enough? that configuration would automatically only apply to Linux builds

@zakhenry
Copy link

@FabianLars can this be bumped to the next milestone since there is open questions now about there being an alternative approach? It's the last item in 2.4 and that's holding back some useful features

@lucasfernog lucasfernog removed this from the 2.4 milestone Mar 20, 2025
@lucasfernog
Copy link
Member

we just released 2.4 fyi :)

@AlexProgrammerDE
Copy link
Contributor Author

what about adding a src-tauri/tauri.linux.conf.json with the following contents instead:

{
  "productName": "soufire"
}

wouldn't that be enough? that configuration would automatically only apply to Linux builds

Hi, that would be a valid alternative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📬Proposal
Development

Successfully merging this pull request may close these issues.

5 participants