Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't eagerly set ControlFlow::Exit (fix #8631) #12632

Conversation

thomaseizinger
Copy link

As discussed at length in #8631, run_iteration is basically unusable currently because it busy-loops the current thread. This shouldn't be the case though because the underlying tao::Runtime allows suspending until an actual event from the OS is generated. However, once ControlFlow::Exit has been set, this remains sticky and cannot be unset.

Local testing on Windows confirms that removing this particular snippet fixes the busy-looping behaviour whilst retaining all other window-related functionality.

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Package Changes Through 92cd207

There are 7 changes which include tauri-cli with minor, tauri-runtime with minor, tauri-runtime-wry with minor, tauri-utils with minor, tauri with minor, @tauri-apps/api with minor, @tauri-apps/cli with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.2.0 2.3.0
tauri-utils 2.1.1 2.2.0
tauri-bundler 2.2.3 2.2.4
tauri-runtime 2.3.0 2.4.0
tauri-runtime-wry 2.3.0 2.4.0
tauri-codegen 2.0.4 2.0.5
tauri-macros 2.0.4 2.0.5
tauri-plugin 2.0.4 2.0.5
tauri-build 2.0.5 2.0.6
tauri 2.2.5 2.3.0
@tauri-apps/cli 2.2.7 2.3.0
tauri-cli 2.2.7 2.3.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@thomaseizinger
Copy link
Author

Hmm, this might actually not fix things. I just realised that run_iteration now never returns.

@thomaseizinger thomaseizinger marked this pull request as draft February 6, 2025 06:57
@thomaseizinger
Copy link
Author

Closing in favor of #12668.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant