fix: don't eagerly set ControlFlow::Exit
(fix #8631)
#12632
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed at length in #8631,
run_iteration
is basically unusable currently because it busy-loops the current thread. This shouldn't be the case though because the underlyingtao::Runtime
allows suspending until an actual event from the OS is generated. However, onceControlFlow::Exit
has been set, this remains sticky and cannot be unset.Local testing on Windows confirms that removing this particular snippet fixes the busy-looping behaviour whilst retaining all other window-related functionality.