fix: don't eagerly set ControlFlow::Exit (fix #8631)#12632
Closed
thomaseizinger wants to merge 2 commits intotauri-apps:devfrom
Closed
fix: don't eagerly set ControlFlow::Exit (fix #8631)#12632thomaseizinger wants to merge 2 commits intotauri-apps:devfrom
ControlFlow::Exit (fix #8631)#12632thomaseizinger wants to merge 2 commits intotauri-apps:devfrom
Conversation
Contributor
Package Changes Through 92cd207There are 7 changes which include tauri-cli with minor, tauri-runtime with minor, tauri-runtime-wry with minor, tauri-utils with minor, tauri with minor, @tauri-apps/api with minor, @tauri-apps/cli with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Contributor
Author
|
Hmm, this might actually not fix things. I just realised that |
Contributor
Author
|
Closing in favor of #12668. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed at length in #8631,
run_iterationis basically unusable currently because it busy-loops the current thread. This shouldn't be the case though because the underlyingtao::Runtimeallows suspending until an actual event from the OS is generated. However, onceControlFlow::Exithas been set, this remains sticky and cannot be unset.Local testing on Windows confirms that removing this particular snippet fixes the busy-looping behaviour whilst retaining all other window-related functionality.