Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce
App::run_return
#12668base: dev
Are you sure you want to change the base?
feat: introduce
App::run_return
#12668Changes from 12 commits
869b09e
6ef503d
930e45f
a495daf
94ae3ef
3b3dd3a
5f4f2f4
9be493e
0325274
9953452
918a1d5
f0580df
075d436
3d88211
ac2711b
fcda384
e04ff09
e48e8c3
71c51ea
5818937
97a18a6
419b084
4d7b761
dad7221
793e2d5
c5aadac
3eacfa5
226adbb
80591e0
93f566c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just used the same error as from the setup callback. It is missing
Send + Sync + 'static
bounds unfortunately but that is already the case and can't be changed now I think.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tried it locally, and
crate::Result<i32>
works for me.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, don't we need to
match event
Ready/Exit
like inApp::run
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not too familiar with this bit and copied what was done for
run_iteration
before. When is the ready event emitted?For exit, given that we now return control flow, I don't think we need to match on the Exit event.