feat: Support custom CFBundleVersion for iOS and macOS #13030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
velocitysystems
force-pushed
the
bundle_version
branch
from
b0eb392 to
7db9c76
Compare
|
@lucasfernog @FabianLars PR has been rebased and is ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #12479 and adds support for specifying a custom
CFBundleVersionfor iOS and macOS.It allows a custom build number to be injected i.e. from CI and used in
Info.plistwhen building an application bundle.Specifically this resolves the issue where multiple builds cannot be submitted to TestFlight for a single version i.e. 1.0.0 (1), 1.0.0 (2) which is a blocking issue for CI/CD automation. It follows the same approach used for specifying
versionCodefor Android and adds a new bundle configuration property for iOS and macOS:bundleVersion.See PR 3216 with related documentation changes.
cc: @lucasfernog