Skip to content

feat(linux): implement custom user data path #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 22, 2021
Merged

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Documentation
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

We spotted the need for this on tauri-apps/tauri#1551

@lucasfernog lucasfernog requested a review from a team as a code owner April 22, 2021 13:00
@lucasfernog lucasfernog requested a review from a team April 22, 2021 13:00
@wusyong
Copy link
Member

wusyong commented Apr 22, 2021

LGTM!
Could you also help updating user_data_path in WebViewBuilder to with_user_data_path and updating its doc?

Btw, should we take this chance to rename the method name? I feel like with_storage_path or with_data_directory is easier for user to understand.

@lucasfernog
Copy link
Member Author

Sounds good, I guess i'll go with with_data_directory.

@lucasfernog lucasfernog requested a review from a team April 22, 2021 14:04
@wusyong wusyong merged commit 1a6c821 into dev Apr 22, 2021
@wusyong wusyong deleted the feat/linux-user-data branch April 22, 2021 14:30
@github-actions github-actions bot mentioned this pull request Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants