Added icons for Substack and Threads #120
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbakerx
requested changes
Dec 28, 2023
There was a problem hiding this comment.
Apologies for the very late review, thank you for the additions! Minor change request as per your note in the PR description:
To avoid the need to scale the icon with transform, the svgs that you are using should have a viewbox attribute declared. With a slight modification to the <Icon/> component, we can pass that viewbox as a prop and set it on the parent <svg/> tag (falling back to my hardcoded 0 0 128 128). Does this make sense?
|
That sounds good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not an svg expert and had to do use transform=scale(xx) to make them fit.