Normative: add Error.isError
#3507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
added
normative change
34 tasks
michaelficarra
approved these changes
Dec 9, 2024
ljharb
force-pushed
the
error.iserror
branch
2 times, most recently
from
0820c3d to
e12b48d
Compare
linusg
reviewed
Mar 18, 2025
spec.html
Outdated
| @@ -31265,7 +31275,7 @@ <h1>Error.prototype.toString ( )</h1> | |||
|
|
|||
| <emu-clause id="sec-properties-of-error-instances"> | |||
| <h1>Properties of Error Instances</h1> | |||
| <p>Error instances are ordinary objects that inherit properties from the Error prototype object and have an [[ErrorData]] internal slot whose value is *undefined*. The only specified uses of [[ErrorData]] is to identify Error, AggregateError, and _NativeError_ instances as Error objects within `Object.prototype.toString`.</p> | |||
| <p>Error instances are ordinary objects that inherit properties from the Error prototype object and have an [[ErrorData]] internal slot whose value is *undefined*. The only specified uses of [[ErrorData]] is to identify Error, AggregateError, and _NativeError_ instances as Error objects within `Object.prototype.toString` and `Error.isError`.</p> | |||
There was a problem hiding this comment.
Maybe we can also add an emu-xref to these while we're here :)
ctcpip
approved these changes
Mar 18, 2025
bakkot
approved these changes
May 21, 2025
bakkot
reviewed
May 21, 2025
ljharb
added a commit
to ljharb/ecma262
that referenced
this pull request
May 21, 2025
ljharb
added
has stage 4
bakkot
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tc39/proposal-is-error#7