Editorial: add a note about synchronicity of SyntheticModule Evaluate #3640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legendecas
force-pushed
the
synthetic-module-evaluate
branch
2 times, most recently
from
6f066a8 to
896bce8
Compare
spec.html
Outdated
| @@ -28871,6 +28871,10 @@ <h1>Evaluate ( ): a Promise</h1> | |||
| 1. Perform ! Call(_pc_.[[Resolve]], *undefined*, « *undefined* »). | |||
| 1. Return _pc_.[[Promise]]. | |||
| </emu-alg> | |||
|
|
|||
| <emu-note> | |||
| <p>The returned promise should always be settled. In InnerModuleEvaluation, a non Cyclic Module Record is evaluated with EvaluateModuleSync, and asserted to return a settled promise.</p> | |||
There was a problem hiding this comment.
That the returned promise here is always settled is obvious, because the second-to-last line calls Call(_pc_.[[Resolve]], *undefined*, « *undefined* »).
However, what we should do is enforce that all non-Cyclic module records must always return a settled promise. I suggest doing it in the Evaluate description at https://tc39.es/ecma262/#table-abstract-methods-of-module-records, so that if hosts provide their own module types they must also follow that requirement.
There was a problem hiding this comment.
Thanks for the suggestion, updated!
legendecas
force-pushed
the
synthetic-module-evaluate
branch
from
896bce8 to
055d4e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not clear if a Synthetic Module's
[[EvaluationSteps]]should be sync or not by reading the steps in Synthetic Module'sEvaluatealgorithm solely.The synchronicity of a Synthetic Module's Evaluate steps is asserted in
EvaluateModuleSync.Add a note at Synthetic Module Evaluate abstract operation about the synchronicity.