Skip to content

Normative: add Math.sumPrecise #3654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Normative: add Math.sumPrecise #3654

wants to merge 4 commits into from

Conversation

bakkot
Copy link
Contributor

@bakkot bakkot commented Jul 17, 2025

Pending stage 4.

@bakkot bakkot added normative change Affects behavior required to correctly evaluate some ECMAScript source text pending stage 4 This proposal has not yet achieved stage 4, but may otherwise be ready to merge. labels Jul 17, 2025
@bakkot bakkot mentioned this pull request Jul 17, 2025
Open
8 tasks
michaelficarra
michaelficarra reviewed Jul 17, 2025
View reviewed changes
michaelficarra
michaelficarra reviewed Jul 17, 2025
View reviewed changes
@ljharb ljharb added has test262 tests proposal This is related to a specific proposal, and will be closed/merged when the proposal reaches stage 4. labels Jul 17, 2025
linusg
linusg suggested changes Jul 22, 2025
View reviewed changes
@bakkot
Copy link
Contributor Author

bakkot commented Jul 23, 2025

Addressed comments. I also pushed up a small tweak to how _count_ is handled to match the prevailing style as seen in e.g. the GroupBy AO.

@bakkot bakkot added has stage 4 This PR represents a proposal that has achieved stage 4, and is ready to merge. and removed pending stage 4 This proposal has not yet achieved stage 4, but may otherwise be ready to merge. labels Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelficarra michaelficarra michaelficarra left review comments

@linusg linusg linusg requested changes

@syg syg syg approved these changes

Assignees
No one assigned
Labels
has stage 4 This PR represents a proposal that has achieved stage 4, and is ready to merge. has test262 tests normative change Affects behavior required to correctly evaluate some ECMAScript source text proposal This is related to a specific proposal, and will be closed/merged when the proposal reaches stage 4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bakkot @syg @michaelficarra @linusg @ljharb