WIP: Cookbook example showing custom calendar proof of concept (without custom calendar object) #2906
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an example of how to approach implementing a custom calendar, after Temporal.Calendar objects are removed.
It's an implementation of a Nepali calendar (described by @kabaros in #2854 (comment)) based on the implementation linked in that comment, as well as the implementation that was based on.
I used inheritance in this example because in this case that's slightly less code to write, but inheritance also makes some operations legal that maybe shouldn't be. (Like,
Temporal.PlainDateTime.from(nepaliPlainDate)
) So it might be better to switch to composition.I'd also like to write a similar example about Hijri dates with manual adjustment (described in #2854 (comment)) but it was easier to do the proof of concept with Nepali calendar first, since there was already an implementation to copy from. I'll be in contact with @khawarizmus about this.
Draft; needs some cleanup, and a cookbook page.