Editorial: Remove 'default' optional parameter from ToTemporalCalendarSlotValue #2913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(This one probably still needs some editorial massaging and needs to be checked with ecmarkup) Co-Authored-By: Richard Gibson <[email protected]>
…rSlotValue First change `ToTemporalMonthDay` to call `GetTemporalCalendarSlotValueWithISODefault`, so the only place which uses the `default` optional parameter is `GetTemporalCalendarSlotValueWithISODefault`. And then handle the `undefined` case directly in `GetTemporalCalendarSlotValueWithISODefault`.
ptomato
approved these changes
Jul 10, 2024
|
Let's do whatever works best for you. |
ptomato
force-pushed
the
calendar-time-zone-removals
branch
from
9ecdec4 to
847b3f2
Compare
|
Merged manually into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First change
ToTemporalMonthDayto callGetTemporalCalendarSlotValueWithISODefault, so the only place which uses thedefaultoptional parameter isGetTemporalCalendarSlotValueWithISODefault. And then handle theundefinedcase directly inGetTemporalCalendarSlotValueWithISODefault.