Polyfill: Check that time is not start-of-day in ToTemporalInstant#3230
Merged
Polyfill: Check that time is not start-of-day in ToTemporalInstant#3230
Conversation
The TemporalInstantString production requires a Time, so `time` will never be `start-of-day` in this code.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3230 +/- ##
==========================================
+ Coverage 96.75% 97.90% +1.14%
==========================================
Files 22 22
Lines 10398 10365 -33
Branches 1859 1815 -44
==========================================
+ Hits 10061 10148 +87
+ Misses 289 198 -91
+ Partials 48 19 -29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ptomato
requested changes
Jan 12, 2026
Collaborator
ptomato
left a comment
There was a problem hiding this comment.
Looks like we can make the same change in the spec text, in ToTemporalInstant step 6.
Co-authored-by: Philip Chimento <philip.chimento@gmail.com>
Contributor
Author
Done in 4392a0a |
ptomato
approved these changes
Jan 13, 2026
Co-authored-by: Philip Chimento <philip.chimento@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TemporalInstantString production requires a Time, so
timewill never bestart-of-dayin this code.