Fix polyfill: Throw RangeError when a timestring has fractional minutes #3236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #3210
The regex parser falls into a corner case for strings with separators that have fractional minutes and no seconds. It ends up parsing
undefinedminutes and interprets the fraction as seconds.Instead of complicating the regex parser, change ParseISODateTime and ParseTemporalTimeString to throw a RangeError if there a fraction is defined, and either: seconds are undefined (safety measure, the regex parser actually takes care of this) or: minutes are undefined and hours are defined.
This takes care of the corner case without complicating the regex parser, for readability.