Remove source phase resolution time negative error types#4194
Remove source phase resolution time negative error types#4194
Conversation
test/language/module-code/source-phase-import/import-source-binding-name.js
Outdated
Show resolved
Hide resolved
|
Instead of doing this, can we just remove This is to avoid having to require another flag, which may prevent some implementations from running the test. |
4913f78 to
3756e28
Compare
<module source> specifier
Updated. Thanks for suggestion, sounds like a good alternative to me. |
3756e28 to
978e07f
Compare
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
Looks good, if Error is something valid to write there to mean "any error"
Hm, I'm not sure that it is.
|
|
Can we just omit |
No, the linter complains about missing test262/tools/lint/lib/checks/negative.py Line 26 in 75fddbd |
|
Then what about completely moving those tests to import("./the-actual-entrypoint_FIXTURE.js").then(() => $DONE(new Error("It should have failed")), () => $DONE()); |
978e07f to
c18c1dd
Compare
|
Updated and verified with d8. |
c18c1dd to
94cf90e
Compare
test/language/module-code/source-phase-import/import-source-binding-name_FIXTURE.js
Outdated
Show resolved
Hide resolved
e721f6b to
8de8598
Compare
8de8598 to
43442b0
Compare
The source phase import binding name tests can be tested more easily with the resolution time negative error types removed, as they are host defined errors.
Refs: #4121 (comment)