Conversation
test/built-ins/Iterator/prototype/take/argument-validation-failure-closes-underlying.js
Show resolved
Hide resolved
Contributor
sosukesuzuki
left a comment
sosukesuzuki
left a comment
There was a problem hiding this comment.
Implementing this normative change is likely to cause https://github.com/tc39/test262/blob/main/test/built-ins/Iterator/prototype/reduce/non-callable-reducer.js to start failing, because the underlying iterator will already be closed during the second call to reduce.
Member
Author
|
Thanks for the review @sosukesuzuki, addressed comments. |
sosukesuzuki
approved these changes
Jan 12, 2025
ptomato
requested changes
Jan 31, 2025
Contributor
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
Thanks. Two comments, but they apply to multiple files.
test/built-ins/Iterator/prototype/drop/argument-validation-failure-closes-underlying.js
Show resolved
Hide resolved
test/built-ins/Iterator/prototype/drop/argument-validation-failure-closes-underlying.js
Outdated
Show resolved
Hide resolved
ptomato
force-pushed
the
test-iterator-helper-argument-validation-closes
branch
from
652ac6c to
7722e98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests for tc39/ecma262#3467, which has consensus and is just waiting for tests.
No existing tests were invalidated as far as I can tell (presumably because if we'd thought to test this behavior then we'd have updated the proposal instead of needing the PR).