Add more tests for Object.prototype.[[SetPrototypeOf]]
#4446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Apr 3, 2025
test/built-ins/Object/prototype/setPrototypeOf-with-non-circular-values.js
Show resolved
Hide resolved
ljharb
approved these changes
Apr 3, 2025
|
|
||
| The value of the [[Prototype]] internal slot of the Object prototype object is | ||
| null and the initial value of the [[Extensible]] internal slot is true. | ||
| features: [Reflect.setPrototypeOf] |
Member
There was a problem hiding this comment.
it would be nice to split the Reflect tests into their own files (4 total) so we have maximal coverage across feature matrices, but not a requirement
ptomato
approved these changes
Apr 17, 2025
Contributor
|
Been approved for 2 weeks, so merging now. Do feel free to submit a follow up with Jordan's suggestion if you're still planning to. |
ptomato
force-pushed
the
test/object-prototype/more-setprototypeof-tests
branch
from
9ce98d3 to
d3f5b42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out, this case fails in engine262, which I’m fixing in:
%Object.prototype%an immutable prototype exotic object engine262/engine262#267