Add coverage for some implementation bugs in Array and TypedArray methods #4477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
added a commit
to es-shims/Array.prototype.with
that referenced
this pull request
May 12, 2025
ljharb
approved these changes
May 12, 2025
ljharb
added a commit
to es-shims/es-arraybuffer-base64
that referenced
this pull request
May 12, 2025
lando-prod-mozilla bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
May 13, 2025
…ototype.with. r=jandem Test case in <tc39/test262#4477>. Differential Revision: https://phabricator.services.mozilla.com/D248928
lando-prod-mozilla bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
May 13, 2025
… array in lastIndexOf. r=jandem Test case in <tc39/test262#4477>. Differential Revision: https://phabricator.services.mozilla.com/D248929
lando-prod-mozilla bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
May 13, 2025
…ototype.with. r=jandem Test case in <tc39/test262#4477>. Differential Revision: https://phabricator.services.mozilla.com/D248928
lando-prod-mozilla bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
May 13, 2025
… array in lastIndexOf. r=jandem Test case in <tc39/test262#4477>. Differential Revision: https://phabricator.services.mozilla.com/D248929
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
May 13, 2025
…ototype.with. r=jandem Test case in <tc39/test262#4477>. Differential Revision: https://phabricator.services.mozilla.com/D248928
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
May 13, 2025
… array in lastIndexOf. r=jandem Test case in <tc39/test262#4477>. Differential Revision: https://phabricator.services.mozilla.com/D248929
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
May 13, 2025
…ototype.with. r=jandem Test case in <tc39/test262#4477>. Differential Revision: https://phabricator.services.mozilla.com/D248928
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
May 13, 2025
… array in lastIndexOf. r=jandem Test case in <tc39/test262#4477>. Differential Revision: https://phabricator.services.mozilla.com/D248929
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
May 14, 2025
…ototype.with. r=jandem Test case in <tc39/test262#4477>. Differential Revision: https://phabricator.services.mozilla.com/D248928 UltraBlame original commit: 1c03eb73265d4c6d57cff099c3f00aaced99075f
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
May 14, 2025
… array in lastIndexOf. r=jandem Test case in <tc39/test262#4477>. Differential Revision: https://phabricator.services.mozilla.com/D248929 UltraBlame original commit: 192b5d74f9ca4a7594142bf8fd789e2d5ab20b9c
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
May 14, 2025
…ototype.with. r=jandem Test case in <tc39/test262#4477>. Differential Revision: https://phabricator.services.mozilla.com/D248928 UltraBlame original commit: 4c54c405baf8acea20927e66c1dc6e9b88c25b25
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
May 14, 2025
… array in lastIndexOf. r=jandem Test case in <tc39/test262#4477>. Differential Revision: https://phabricator.services.mozilla.com/D248929 UltraBlame original commit: a7c3286c781fa3d67f2b75540b9be2c476e523a0
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
May 14, 2025
…ototype.with. r=jandem Test case in <tc39/test262#4477>. Differential Revision: https://phabricator.services.mozilla.com/D248928 UltraBlame original commit: 1c03eb73265d4c6d57cff099c3f00aaced99075f
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
May 14, 2025
… array in lastIndexOf. r=jandem Test case in <tc39/test262#4477>. Differential Revision: https://phabricator.services.mozilla.com/D248929 UltraBlame original commit: 192b5d74f9ca4a7594142bf8fd789e2d5ab20b9c
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
May 14, 2025
…ototype.with. r=jandem Test case in <tc39/test262#4477>. Differential Revision: https://phabricator.services.mozilla.com/D248928 UltraBlame original commit: 4c54c405baf8acea20927e66c1dc6e9b88c25b25
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
May 14, 2025
… array in lastIndexOf. r=jandem Test case in <tc39/test262#4477>. Differential Revision: https://phabricator.services.mozilla.com/D248929 UltraBlame original commit: a7c3286c781fa3d67f2b75540b9be2c476e523a0
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
May 14, 2025
…ototype.with. r=jandem Test case in <tc39/test262#4477>. Differential Revision: https://phabricator.services.mozilla.com/D248928 UltraBlame original commit: 1c03eb73265d4c6d57cff099c3f00aaced99075f
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
May 14, 2025
… array in lastIndexOf. r=jandem Test case in <tc39/test262#4477>. Differential Revision: https://phabricator.services.mozilla.com/D248929 UltraBlame original commit: 192b5d74f9ca4a7594142bf8fd789e2d5ab20b9c
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
May 14, 2025
…ototype.with. r=jandem Test case in <tc39/test262#4477>. Differential Revision: https://phabricator.services.mozilla.com/D248928 UltraBlame original commit: 4c54c405baf8acea20927e66c1dc6e9b88c25b25
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
May 14, 2025
… array in lastIndexOf. r=jandem Test case in <tc39/test262#4477>. Differential Revision: https://phabricator.services.mozilla.com/D248929 UltraBlame original commit: a7c3286c781fa3d67f2b75540b9be2c476e523a0
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
May 15, 2025
…ototype.with. r=jandem Test case in <tc39/test262#4477>. Differential Revision: https://phabricator.services.mozilla.com/D248928
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
May 15, 2025
… array in lastIndexOf. r=jandem Test case in <tc39/test262#4477>. Differential Revision: https://phabricator.services.mozilla.com/D248929
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
May 15, 2025
…ototype.with. r=jandem Test case in <tc39/test262#4477>. Differential Revision: https://phabricator.services.mozilla.com/D248928
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
May 15, 2025
… array in lastIndexOf. r=jandem Test case in <tc39/test262#4477>. Differential Revision: https://phabricator.services.mozilla.com/D248929
gibson042
approved these changes
May 15, 2025
test/built-ins/TypedArray/prototype/slice/speciesctor-return-same-buffer-with-offset.js
Outdated
Show resolved
Hide resolved
SpiderMonkey doesn't handle this correctly for `Array.prototype.with`.
V8 doesn't handle this correctly for zero length typed arrays.
…ed)Array.prototype.with JSC doesn't handle this correctly for `TypedArray.prototype.with`.
…rototype.with V8 doesn't handle this case correctly.
SpiderMonkey doesn't handle this case correctly.
…backing buffer JSC doesn't handle this case correctly.
…ype.subarray JSC doesn't handle this case correctly.
ptomato
force-pushed
the
typedarray-coverage
branch
from
34f0eb1 to
64accef
Compare
ptomato
approved these changes
May 30, 2025
|
Regarding the However, I was also wondering if that is a spec omission and asked in es.discourse.group. At first sight it seems a bit odd to preserve the |
You might get more response there if you included a code sample that would show the difference. Personally I find the ArrayBuffer spec language difficult to reason about. |
I've been slowly working on that, and just opened tc39/ecma262#3629 for some preliminary feedback. |
|
@ptomato thanks for the tip, tried to add a little snippet, basically a smaller version of the test. Since it involved "detaching" a buffer at some point, it assumes there is some test or host engine facility to do that. In my example I used the QuickJS test262 runner convention. https://es.discourse.group/t/typedarray-subarray-byteoffset-with-detached-buffers/2381/2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coverage for some implementation bugs in JSC, V8, and SpiderMonkey.