Conversation
cb0304c to
5e52386
Compare
Contributor
|
I don't feel confident reviewing the shell code here; can we move this into python somehow? |
ljharb
approved these changes
Jul 28, 2025
Member
ljharb
left a comment
There was a problem hiding this comment.
shell code lgtm; i wouldn't be able to review it if moved to python, but don't let that stop you if you feel it best :-)
5e52386 to
086bdf1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As seen at https://github.com/tc39/test262/actions/runs/16462995254/job/46533977407?pr=4545 for the 1577 changed files of #4545