Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pref: search index #1241

Closed
wants to merge 8 commits into from
Closed

pref: search index #1241

wants to merge 8 commits into from

Conversation

tea-artist
Copy link
Contributor

No description provided.

@tea-artist tea-artist added the preview This issue is already ready for preview label Jan 11, 2025
@tea-artist tea-artist marked this pull request as draft January 11, 2025 15:20
@tea-artist tea-artist changed the title chore: tmp pref: search index Jan 11, 2025
Copy link

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-1241.sealoshzh.site

@caoxing9 caoxing9 force-pushed the perf/add-search-index branch from 2edbf9f to 628cb4a Compare January 12, 2025 10:11
Copy link

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-1241.sealoshzh.site

@caoxing9 caoxing9 marked this pull request as ready for review January 12, 2025 12:32
Copy link

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-1241.sealoshzh.site

@caoxing9 caoxing9 force-pushed the perf/add-search-index branch from 0f4ef4c to 757d362 Compare January 12, 2025 13:08
Copy link

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-1241.sealoshzh.site

Copy link

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-1241.sealoshzh.site

excSqls.push(this.getCreateGinIndexSql(dbFieldName));
});
console.log('ppppppp', excSqls);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@@ -182,7 +199,7 @@ export class VectorTransform {
to_char((elem::timestamp AT TIME ZONE ?), 'YYYY-MM-DD HH24:MI:SS'),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should use the formatter in the field to perform the conversion.

return knex
.raw(
`?? = to_tsvector('simple',
COALESCE(
(
SELECT string_agg(elem::text, ' ')
FROM jsonb_array_elements_text(??::jsonb) as elem
FROM jsonb_array_elements_text(${prefix}??::jsonb) as elem
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all ::jsonb is not nessesary

Copy link

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-1241.sealoshzh.site

Copy link

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-1241.sealoshzh.site

2 similar comments
Copy link

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-1241.sealoshzh.site

Copy link

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-1241.sealoshzh.site

@caoxing9 caoxing9 force-pushed the perf/add-search-index branch from 4451753 to 61f41d9 Compare January 13, 2025 09:20
Copy link

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-1241.sealoshzh.site

Copy link

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-1241.sealoshzh.site

@caoxing9 caoxing9 closed this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview This issue is already ready for preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants