fix: formula reset formatting when expression error #1997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where formula field formatting is not reset when the expression has an error. The change ensures that when a formula expression contains errors, the formatting is properly reset to default values.
- Added error tracking to the
calculateTypedValuefunction to detect when formula expressions fail to parse - Modified the formatting reset logic to trigger when there's an expression error, not just when the cell value type changes
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| } = calculateTypedValue(fields, expression); | ||
|
|
||
| const onExpressionChange = (expr: string) => { | ||
| const { cellValueType: newCellValueType } = calculateTypedValue(fields, expr); |
There was a problem hiding this comment.
The hasError property from calculateTypedValue is not being destructured here, which means the error state won't be available for the formatting reset logic in onExpressionChange. This could lead to inconsistent behavior where errors in the new expression aren't properly handled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.