-
-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Image Preview #954
base: develop
Are you sure you want to change the base?
Conversation
@boris-w , I created a zoom in/out icon component, but it won't display in imagePreview. I don't know how to solve this problem and I don't understand the feature of image dragging, can you give me some help? |
Do you mean the imported icons don't show up? |
Our icons are maintained on figma and synchronized to icons packages via scripts, give me a moment to think about how to collaborate on icon changes! |
my icon components are copied from iconfont,so it doesn't show successful. I want to complete the pr, it is necessary to implement icon components |
Today I'll update the icons you need to the develop branch, you just need to merge the develop. |
Related: #996 |
thanks, could you add a reset icon component? , It's necessary to reset image for users |
Reset -> RefreshCcw |
@boris-w ,could you explain about dragging ? I don't understand the functionality |
Dragging is considered for situations when the image is enlarged beyond the current screen size, requiring the ability to drag in order to view parts of the image that extend beyond the screen. |
@boris-w hello, I completed the pr ,can you review it? |
It looks like you had a problem with the merge, a lot more unnecessary changes were made. |
4b8d0a2
to
d1cd934
Compare
close #767
tasks: