Add explicit inline to constexpr namespace variables #346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The C++17 specs are not very clear, but inline is not implicit for a constexpr namespace variable. Add it explicit to ensure no ODR violations.
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds explicit inline specifiers to constexpr namespace variables to prevent potential ODR (One Definition Rule) violations. The C++17 specification is unclear about whether inline is implicit for constexpr namespace variables, so this change makes it explicit for safety.
Key changes:
- Added
inlinekeyword to allconstexprnamespace-scope variable declarations - Reordered include statements in one header file for consistency
- Removed references to a module interface file from Visual Studio project files
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/scan_codec.hpp | Added inline to constexpr array J and reordered includes |
| src/jpeg_marker_code.hpp | Added inline to three constexpr variables |
| src/constants.hpp | Added inline to all constexpr constant declarations |
| src/CharLS.vcxproj.filters | Removed reference to charls.ixx module file |
| src/CharLS.vcxproj | Removed reference to charls.ixx module file |
| CharLS.sln.DotSettings | Updated code analysis settings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C++17 specs are not very clear, but inline is not implicit for a constexpr namespace variable. Add it explicit to ensure no ODR violations.