Skip to content

Conversation

@bongtta
Copy link
Contributor

@bongtta bongtta commented Nov 26, 2025

📌 Summary

📚 Tasks

  • 공연 미리듣기 api 연동
  • 원형 링 qa 해결
  • 404 페이지 자체qa 해결

👀 To Reviewer

원래 사용자가 좋아요 누른 공연들이 미리듣기에 뜨는 건데 서버에서 그렇게 구현 안 했다고 해서 지금은 좋아요 안 누른 공연들도 뜨긴 합니다~

그리고 저부분 가로스크롤 된다고 했던 것 같기도 하고 아닌 것 같기도 한데... 일단 졸려서 pass... 맞다고 하면 반영할게옇

📸 Screenshot

2025-11-27.5.23.11.mov

@bongtta bongtta self-assigned this Nov 26, 2025
@bongtta bongtta requested a review from a team as a code owner November 26, 2025 20:40
@bongtta bongtta added the ✨ Feature 기능 개발 label Nov 26, 2025
@bongtta bongtta linked an issue Nov 26, 2025 that may be closed by this pull request
@bongtta bongtta added the 채은 🪕 채은 label Nov 26, 2025
@changeset-bot
Copy link

changeset-bot bot commented Nov 26, 2025

⚠️ No Changeset found

Latest commit: 4b9cb0d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@bongtta bongtta changed the title Feat/#703/preview song api Feat(client): 공연 미리듣기 api 연동 Nov 26, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2025

🏴‍☠️ Storybook 확인: 🔗 https://677bd6bc4909f2f48f4e0f42-nqyprpcnhg.chromatic.com/

...themeVars.display.flexJustifyAlignCenter,
flexDirection: 'column',
height: 'calc(100dvh - 14rem)',
flex: 1,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

홈으로 돌아가기 버튼이 하단에 안 붙어있어서 추가했어요

Comment on lines -160 to +164
inset: '-1.5px',
transform: 'rotate(-90deg)',
width: '44px',
height: '44px',
top: '50%',
left: '50%',
transform: 'translate(-50%, -50%) rotate(-90deg)',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기존 속성은 safari에서 svg 스케일이랑 회전 시 좌표가 달라져서 원 중심이 틀어졌어요.
svg를 width/height: 44px로 고정하고, top/left: 50% + translate(-50%, -50%)으로만 가운데 정렬하도록 해서 viewBox랑 실제 렌더링 크기를 1:1로 맞췄습니다

Copy link
Member

@m2na7 m2na7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good 가로스크롤까지 반영하면될듯요 ㅎㅎ @bongtta

Comment on lines +42 to 44
if (!isPending && !performances) {
return null;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요렇게 하면 ux가 자연스러운가요ㅕ ??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ Feature 기능 개발 채은 🪕 채은

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: 공연 미리듣기 api 연동

3 participants