Feat(client): 공연 미리듣기 api 연동 #712
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
|
🏴☠️ Storybook 확인: 🔗 https://677bd6bc4909f2f48f4e0f42-nqyprpcnhg.chromatic.com/ |
bongtta
commented
Nov 26, 2025
| ...themeVars.display.flexJustifyAlignCenter, | ||
| flexDirection: 'column', | ||
| height: 'calc(100dvh - 14rem)', | ||
| flex: 1, |
Contributor
Author
There was a problem hiding this comment.
홈으로 돌아가기 버튼이 하단에 안 붙어있어서 추가했어요
bongtta
commented
Nov 26, 2025
Comment on lines
-160
to
+164
| inset: '-1.5px', | ||
| transform: 'rotate(-90deg)', | ||
| width: '44px', | ||
| height: '44px', | ||
| top: '50%', | ||
| left: '50%', | ||
| transform: 'translate(-50%, -50%) rotate(-90deg)', |
Contributor
Author
There was a problem hiding this comment.
기존 속성은 safari에서 svg 스케일이랑 회전 시 좌표가 달라져서 원 중심이 틀어졌어요.
svg를 width/height: 44px로 고정하고, top/left: 50% + translate(-50%, -50%)으로만 가운데 정렬하도록 해서 viewBox랑 실제 렌더링 크기를 1:1로 맞췄습니다
m2na7
approved these changes
Nov 27, 2025
Comment on lines
+42
to
44
| if (!isPending && !performances) { | ||
| return null; | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
📚 Tasks
👀 To Reviewer
원래 사용자가 좋아요 누른 공연들이 미리듣기에 뜨는 건데 서버에서 그렇게 구현 안 했다고 해서 지금은 좋아요 안 누른 공연들도 뜨긴 합니다~
그리고 저부분 가로스크롤 된다고 했던 것 같기도 하고 아닌 것 같기도 한데... 일단 졸려서 pass... 맞다고 하면 반영할게옇
📸 Screenshot
2025-11-27.5.23.11.mov