Conversation
davidfirst
reviewed
Nov 14, 2025
davidfirst
reviewed
Nov 14, 2025
davidfirst
reviewed
Nov 14, 2025
davidfirst
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves schema extraction accuracy, module indexing, and internal module resolution across several core parts of the API reference pipeline.
1. VariableDeclaration and ObjectLiteral handling
Fixes incorrect schema extraction for
VariableDeclarationnodes initialized with object literals that contain identifier references.Previously:
UnImplementedSchemaor inlinedFunctionLikeSchemanodes due to QuickInfo-based heuristics misclassifying object literals as arrow functions.Now:
VariableDeclarationTransformerexplicitly detectsObjectLiteralExpressioninitializers and callscomputeSchema() to construct accurate nested schemas.ObjectLiteralExpressionTransformerresolves previously unhandledUnImplementedSchemavalues by inspecting property initializers:getTypeRef() /getTypeRefForExternalNode() to produce properTypeRefSchemas.resolveType() using parsed QuickInfo.SchemaExtractorContextnow prioritizes object-literal detection inunknownExactType() before function heuristics, preventing false positives forFunctionLikeSchema.createFunctionSchema() (^\s*([^)]+)\s*(?:=>|:)\s*(.+)$) to prevent over-matching and ensure stable parsing of function signatures.2. Internal module extraction overhaul + recursive type-ref closure
Major overhaul of how internal (non-exported) modules are discovered, walked, and materialized.
Key changes:
Introduces
context.buildTopLevelNameIndex()to efficiently map names → top-level declarations.Internal modules now derive solely from identifiers not exported via the main entry point.
Avoids any reprocessing of exported symbols handled by ExportDeclarationTransformer.
Adds recursive closure over internal type references inside the same file:
collectSameFileInternalTypeRefs()walks the generated schema graph and finds all internal TypeRefSchema nodes belonging to the same file.computeInternalModules()now performs a BFS:Result: internal types are now fully resolved, transitive, and correctly represented.
3. includeFiles support for explicit internal parsing
Adds the ability for consumers to explicitly include additional files for full schema extraction
Behavior:
APISchema.