PR | Hanko Remix Starter | Updated Starter -> Main #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Did some minor changes
FreddyDevelop
requested changes
Apr 7, 2025
LICENSE
Outdated
There was a problem hiding this comment.
The license should not be deleted,
app/routes/dashboard.tsx
Outdated
| <HankoProfile /> | ||
| </div> | ||
| ) | ||
| const dashboardPage = () => { |
There was a problem hiding this comment.
Please use uppercase for the first letter, as the other components.
Suggested change
| const dashboardPage = () => { | |
| const DashboardPage = () => { |
app/routes/profile.tsx
Outdated
| return { hankoUrl: hankoUrl }; | ||
| }; | ||
|
|
||
| const profilePage = () => { |
There was a problem hiding this comment.
Please use uppercase for the first letter, as the other components.
Suggested change
| const profilePage = () => { | |
| const ProfilePage = () => { |
There was a problem hiding this comment.
Fixed your feedback in the latest commit
Readded the License and changed letters for page components
FreddyDevelop
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My pull request for the Hanko Remix starter.
If theres anything that needs to be changed lmk and Ill look into it!