Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing new status on deals.list and deals.info #756

Closed
wants to merge 2 commits into from
Closed

Add missing new status on deals.list and deals.info #756

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0558fc7
Add missing `new` status on deals.list and deals.info
lowiebenoot Nov 15, 2023
1d72289
`new` shouldn't be an option on the status filter, as `open` returns …
lowiebenoot Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apiary.apib
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2249,7 +2249,7 @@ Get a list of deals.
+ responsible_user_id: `98b2863e-7b01-4232-82f5-ede1f0b9db22`, `98b2863e-7b01-4232-82f5-ede1f0b9db24` (array[string], optional)
+ updated_since: `2018-02-11T16:45:30+00:00` (string, optional) - This date is inclusive
+ created_before: `2018-02-11T16:45:30+00:00` (string, optional) - This date is inclusive
+ status: `open`, `won`, `lost` (array[string], optional)
+ status: `new`, `open`, `won`, `lost` (array[string], optional)
lowiebenoot marked this conversation as resolved.
Show resolved Hide resolved
+ page (Page, optional)
+ sort (array, optional)
+ (object)
Expand Down Expand Up @@ -2338,6 +2338,7 @@ Get details for a single deal.
+ reference: `2017/2` (string)
+ status: `won` (enum)
+ Members
+ new
+ open
+ won
+ lost
Expand Down
3 changes: 2 additions & 1 deletion src/03-deals/deals.apib
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Get a list of deals.
+ responsible_user_id: `98b2863e-7b01-4232-82f5-ede1f0b9db22`, `98b2863e-7b01-4232-82f5-ede1f0b9db24` (array[string], optional)
+ updated_since: `2018-02-11T16:45:30+00:00` (string, optional) - This date is inclusive
+ created_before: `2018-02-11T16:45:30+00:00` (string, optional) - This date is inclusive
+ status: `open`, `won`, `lost` (array[string], optional)
+ status: `new`, `open`, `won`, `lost` (array[string], optional)
+ page (Page, optional)
+ sort (array, optional)
+ (object)
Expand Down Expand Up @@ -118,6 +118,7 @@ Get details for a single deal.
+ reference: `2017/2` (string)
+ status: `won` (enum)
+ Members
+ new
+ open
+ won
+ lost
Expand Down